Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat/cli #572

Open
wants to merge 25 commits into
base: development
Choose a base branch
from
Open

feat/cli #572

wants to merge 25 commits into from

Conversation

JayaKrishnaNamburu
Copy link
Member

No description provided.

@JayaKrishnaNamburu JayaKrishnaNamburu requested a review from Utwo May 14, 2021 17:45
@codecov
Copy link

codecov bot commented May 14, 2021 •
edited
Loading

Codecov Report

Merging #572 (859f7e6) into development (9fdf16c) will not change coverage.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##           development     #572   +/-   ##
============================================
  Coverage        70.91%   70.91%           
============================================
  Files              208      208           
  Lines             7561     7561           
  Branches          2113     2113           
============================================
  Hits              5362     5362           
  Misses            2022     2022           
  Partials           177      177
Impacted Files Coverage Δ
packages/teleport-publisher-disk/src/utils.ts 89.47% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9fdf16c...859f7e6. Read the comment docs.

@JayaKrishnaNamburu JayaKrishnaNamburu changed the title Feat/cli feat/cli May 15, 2021
@JayaKrishnaNamburu JayaKrishnaNamburu self-assigned this May 16, 2021
Utwo
Utwo suggested changes May 17, 2021
View reviewed changes
packages/teleport-cli/Readme.md Show resolved Hide resolved
packages/teleport-cli/src/constants.ts Outdated
}

export const BASE_URL = 'https://us-central1-croapp-dev.cloudfunctions.net/repl-api/'
export const STUDIO_URL = 'https://playground-api-production-v5.services.teleporthq.io/project/'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this URL be the frontend one?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If not, it's a little tricky, because we might upgrade the backend in the future, let's say from v5 to v6.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So in that case, an old version of the CLI will not work anymore

packages/teleport-cli/src/services/index.ts Outdated
import { getPackageJSON } from '../utils'

export const fetchUIDLFromREPL = async (url: string): Promise<Record<string, unknown>> => {
const id = url.match(UUDID_REGEX)[0]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think here is better to use this https://www.npmjs.com/package/uuid#uuidvalidatestr

@Utwo
Copy link
Contributor

Utwo commented May 17, 2021

And please a minimal Readme in teleport-mapper

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Utwo Utwo Utwo requested changes

Assignees

@JayaKrishnaNamburu JayaKrishnaNamburu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JayaKrishnaNamburu @Utwo