Rollout workload when disruption budget prevents pod eviction #3808
+578
−255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eviction might be prevented when a disruption budget is in place because Kubernetes will not start a new pod before until after the eviction. This commit introduces three ways to mitigate this problem. 1. When multiple evictions are made, and some of those evictions have succeeded, then a good strategy is to just wait until the evicted pods are recreated, and then continue to evict others. 2. For a deployment or argo-rollout, applying a patch with a restart annotation causes all pods to be redeployed in a manner that doesn't disrupt the budget. 3. For replicasets and statefulsets, the approach is to scale up above the budget threshold, evict the pod, and then scale back down again. Signed-off-by: Thomas Hallgren <thomas@tada.se>
thallgren
added
the
ok to test
github-actions
bot
removed
the
ok to test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Eviction might be prevented when a disruption budget is in place because Kubernetes will not start a new pod until after the eviction. This commit introduces three ways to mitigate this problem.