Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable dependency analysis and update dependencies #82

Merged
merged 2 commits into from
Dec 18, 2024

Conversation

robwtelicent
Copy link
Contributor

@robwtelicent robwtelicent commented Dec 18, 2024

This PR adds the execution of the analyze-only goal on the Maven Dependency Plugin and the addition (or removal) of dependencies to each module, as identified by the plugin.

A number of dependencies were found to be required that are not detected by the plugin and this is likely to be because they make use of annotations, as described here https://maven.apache.org/plugins/maven-dependency-plugin/examples/exclude-dependencies-from-dependency-analysis.html. The plugin has been been configured to ignore these dependencies.

Copy link
Contributor

@rvesse rvesse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for the most part, only one dependency that may need a <scope> tweak

As discussed at stand up probably is worth doing for these modules as it decreases the likelihood of getting dependency conflicts due to Maven's "closest dependency wins" rule

event-sources/event-source-kafka/pom.xml Show resolved Hide resolved
@robwtelicent robwtelicent merged commit 99d0f83 into main Dec 18, 2024
27 checks passed
@robwtelicent robwtelicent deleted the declare-dependencies branch December 18, 2024 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants