Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navbar hides initial content when jumping to in-page anchor #8

Merged
merged 1 commit into from
Feb 14, 2014
Merged

Navbar hides initial content when jumping to in-page anchor #8

merged 1 commit into from
Feb 14, 2014

Conversation

pierre-rouanet
Copy link
Contributor

Hi,

First, thanks for the awesome theme! It's really beautiful and efficient.

I've realised that there is the same issue than the one described in twbs/bootstrap#1768.

I don't know if it's intended or not. Anyways, I've copied their solution and added it to your theme.
Yet, I don't get it why I can't retrieve the height from the navbar. Thus in my solution I directly use the raw value in the code.

// var navHeight = $(".navbar").height(),
 var navHeight = 40,

Let me know what you think.

Best regards,
Pierre

@tell-k tell-k merged commit 05ac605 into tell-k:master Feb 14, 2014
@tell-k
Copy link
Owner

tell-k commented Feb 14, 2014

Hi @pierre-rouanet

I'm sorry for the late reply.
I have approved your request.
Before the next release, maybe i'll modify your code a little bit.
Thanks for your help.

@pierre-rouanet pierre-rouanet deleted the navbar__hidden_anchor branch February 14, 2014 14:26
@pierre-rouanet
Copy link
Contributor Author

Hi,

No problem for the delay.
I'm sure you can make my patch better, I'm clearly not a web developer :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants