GH-134: localstack compatibility for aws providers #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JacobJohansen
force-pushed
the
GH-134
branch
from
9d8736e
to
313ea3b
Compare
|
fixed the formatting |
|
using act, https://github.com/nektos/act my branch now has the same output as the master branch |
|
+1 would love to get this change approved |
|
Thanks @JacobJohansen looks good! |
kaplanelad
added a commit
that referenced
this pull request
Oct 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
#134
Description
Add environment variable to allow custom aws endpoint for aws providers to work with localstack
Motivation and Context
Allow developers to use services locally that we use for our deployed environments
How Has This Been Tested?
Tested against localstack when
AWS_ENDPOINTenvironment variable is set.Tested against live aws when
AWS_ENDPOINTenvironment variable is absentChecklist