Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix(273): Teller file name inconsistencies #274

Merged
merged 2 commits into from
May 15, 2024

Conversation

stvnksslr
Copy link
Contributor

@stvnksslr stvnksslr commented May 14, 2024

reuse the variable declared for the default to prevent drift between teller new and file lookup

fixes #273

Rationale for changes to tests
if the -c flag is passed teller should use this name/path and test to make sure its finding the correct one.

if no config is passed the config naming should follow the convention of teller new

❯ ls -lah | grep teller.yml
.rw-r--r--   182 stvnksslr 14 May 12:19  .teller.yml
.rw-r--r--   182 stvnksslr 14 May 12:51  teller.yml

teller on  bugfix/273 [!?] via 🦀 v1.79.0-nightly
❯ ./target/debug/teller -c teller.yml show
[aws_secretsmanager_1 (aws_secretsmanager)]: TOKEN = ***

teller on  bugfix/273 [!?] via 🦀 v1.79.0-nightly
❯ ./target/debug/teller show
[aws_secretsmanager_1 (aws_secretsmanager)]: TOKEN = ***

…t to prevent drift between teller new and file lookup
@stvnksslr stvnksslr changed the title bugfix(teller file name): re use the variable declared for the defaul… bugfix(teller file name): May 14, 2024
…nfig is specificed it should use that name, if no name is specificed it should use the defaults
@stvnksslr stvnksslr changed the title bugfix(teller file name): bugfix(273): Teller file name inconsistencies May 14, 2024
@jondot
Copy link
Contributor

jondot commented May 15, 2024

Looks great, thanks!

@jondot jondot merged commit 5d0d60a into tellerops:master May 15, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: Teller default path incorrect as per the docs teller.yml vs .teller.yml
2 participants