Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allowances - Revoke - UI #605

Closed
ezra-sg opened this issue Sep 18, 2023 · 0 comments
Closed

Allowances - Revoke - UI #605

ezra-sg opened this issue Sep 18, 2023 · 0 comments
Assignees
Labels
🦕 Allowances 🚫 Blocked Can't proceed with this issue or pull request 🎯 Feature New feature

Comments

@ezra-sg
Copy link
Contributor

ezra-sg commented Sep 18, 2023

blocked by #206

Create a modal UI for editing the allowances for an asset

  • there should be a pencil icon next to the amounts in the table, which has proper a11y
  • clicking the pencil icon in the table should launch a modal for that asset
    • modal should be its own component, something like EditAllowanceModal
  • the modal title should be "Define new {symbol | asset name up to 20 characters} allowance for {spender contract - external link}"
  • there should be three options, None Unlimited and Custom (all should be added to i18n)
  • custom should have a currency input which is disabled unless Custom is selected
    • if you edit the token amount input, then click a different option like None, the token amount input should be cleared
  • TODO should there be any constraints on the currency input, like number of decimals? limit to 999T, max decimals is decimals for contract. for NFTs, only integers allowed
  • confirm should do nothing (implemented in Allowances - Revoke - API Integration #606)
  • cancel and clicking outside the modal should close the modal

Update allowances table to include revoke checkboxes

  • allowances table should get a new column for selecting rows
  • clicking the checkbox in the header cell should select all visible rows
  • the table controls at the foot of the table should be updated to include a new layout to allow for arbitrary text, like 'x rows selected' (see below image)

Image

@ezra-sg ezra-sg added 🚫 Blocked Can't proceed with this issue or pull request 🎯 Feature New feature 🦕 Allowances labels Sep 20, 2023
@ezra-sg ezra-sg mentioned this issue Oct 19, 2023
10 tasks
@ezra-sg ezra-sg self-assigned this Dec 4, 2023
donnyquixotic added a commit that referenced this issue Dec 15, 2023
@pmjanus pmjanus closed this as completed Aug 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🦕 Allowances 🚫 Blocked Can't proceed with this issue or pull request 🎯 Feature New feature
Projects
None yet
Development

No branches or pull requests

2 participants