Incorporating Greymass Fuel into the sign transaction process (web wallet) #128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for wallet-dev-mainnet ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for wallet-staging ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
…n-transaction-process-web-wallet-1
…n-transaction-process-web-wallet-1
…n-transaction-process-web-wallet-1
…n-transaction-process-web-wallet-1
karynemayer
reviewed
Feb 7, 2023
karynemayer
reviewed
Feb 7, 2023
karynemayer
reviewed
Feb 7, 2023
poplexity
approved these changes
Feb 7, 2023
There was a problem hiding this comment.
👍
Looks good, please address @karynemayer's comments before merge.
…process-web-wallet-1' of https://github.com/telosnetwork/telos-wallet into 63-incorporate-greymass-fuel-into-the-sign-transaction-process-web-wallet-1
karynemayer
approved these changes
Feb 9, 2023
karynemayer
deleted the
63-incorporate-greymass-fuel-into-the-sign-transaction-process-web-wallet-1
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #63
Description
Having finished the same solution for the OBE website and approved by Aaron cox from Graymass himself, I migrate that solution to this website making minor adjustments (like migrating to javascript and integrating with i18n library for translation).
Test scenarios
This is very difficult to test. You need to log in with an account with limited resources and then attempt to push a transaction that needs that resource.
Checklist: