Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removing fuel when not supported #135

Conversation

Viterbo
Copy link
Collaborator

@Viterbo Viterbo commented Feb 14, 2023

Fixes #134

Description

The fuel service is working as expected in the chains that are supported but are introducing problems in the not supported ones. This PR fixes the problem.

Test scenarios

  • Login to testnet
  • open the browser inspector and enter tab Network
  • modify filters, select: Fetch/XHR
  • try to sign any transaction (send tokens, stake or unstake)
  • You should not see a POST request like this: https://telos.greymass.com/v1/resource_provider/request_transaction
  • You should be able to perform the signing as regularly (without fuel)

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have cleaned up the code in the areas my change touches
  • My changes generate no new warnings
  • I have checked my code and corrected any misspellings
  • I have removed any unnecessary console messages

@Viterbo Viterbo self-assigned this Feb 14, 2023
@netlify
Copy link

netlify bot commented Feb 14, 2023

Deploy Preview for wallet-staging ready!

Name Link
🔨 Latest commit 7a5e037
🔍 Latest deploy log https://app.netlify.com/sites/wallet-staging/deploys/63edb8fde99b3f000870436b
😎 Deploy Preview https://deploy-preview-135--wallet-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

ezra-sg
ezra-sg approved these changes Feb 15, 2023
@Viterbo Viterbo requested a review from karynemayer February 16, 2023 05:03
@donnyquixotic donnyquixotic merged commit 8a961e3 into develop Feb 17, 2023
@donnyquixotic donnyquixotic deleted the 134-make-sure-fuel-do-not-break-if-the-chain-do-not-support-the-service-wallet branch February 17, 2023 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants