Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wallet balance stale prices #664

Merged
merged 4 commits into from
Nov 14, 2023
Merged

Conversation

Viterbo
Copy link
Collaborator

@Viterbo Viterbo commented Nov 13, 2023

Fixes #542

Description

The text explaining the price was changed but not as big as it was proposed because it was too big and created a super long tooltip. Then a hardcoded number was refactored for a constant

Test scenarios

  • Go to balance page
  • check the staked token balance. It has a tooltip with the new text.

Screenshots

image

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have cleaned up the code in the areas my change touches
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings
  • I have removed any unnecessary console messages
  • I have included all english text to the translation file and/or created a new issue with the required translations for the currently supported languages
  • I have tested for mobile functionality and responsiveness
  • I have added appropriate test coverage

@Viterbo Viterbo self-assigned this Nov 13, 2023
@Viterbo Viterbo linked an issue Nov 13, 2023 that may be closed by this pull request
2 tasks
Copy link

netlify bot commented Nov 13, 2023

Deploy Preview for wallet-staging ready!

Name Link
🔨 Latest commit 29420f5
🔍 Latest deploy log https://app.netlify.com/sites/wallet-staging/deploys/65539c8c78dab8000881564c
😎 Deploy Preview https://deploy-preview-664--wallet-staging.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Nov 13, 2023

Deploy Preview for wallet-develop-mainnet ready!

Name Link
🔨 Latest commit 29420f5
🔍 Latest deploy log https://app.netlify.com/sites/wallet-develop-mainnet/deploys/65539c8c0715c00008a41f19
😎 Deploy Preview https://deploy-preview-664--wallet-develop-mainnet.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Viterbo Viterbo marked this pull request as ready for review November 13, 2023 19:38
@donnyquixotic donnyquixotic merged commit 8a07928 into develop Nov 14, 2023
@donnyquixotic donnyquixotic deleted the 542-wallet-balance-stale-prices branch November 14, 2023 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wallet Balance Stale Prices
2 participants