#645 | IPFS NFTs #665
Merged
#645 | IPFS NFTs #665
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into 658-erc1155-transfers-and-owners
…twork/telos-wallet into 658-erc1155-transfers-and-owners
…58-erc1155-transfers-and-owners
…58-erc1155-transfers-and-owners
✅ Deploy Preview for wallet-staging ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for wallet-develop-mainnet ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
ezra-sg
commented
Nov 13, 2023
| @@ -92,7 +92,7 @@ export default abstract class EVMChainSettings implements ChainSettings { | |||
|
|
|||
| // Interceptor handlers -- these handlers are used to limit the number of concurrent requests | |||
| // eslint-disable-next-line @typescript-eslint/no-explicit-any | |||
| const requestHandler = (value: InternalAxiosRequestConfig) => new Promise<InternalAxiosRequestConfig<any>>((resolve) => { | |||
| const requestHandler = (value: any) => new Promise<any>((resolve) => { | |||
There was a problem hiding this comment.
fix new error saying InternalAxiosRequestConfig does not exist
ezra-sg
commented
Nov 13, 2023
| @@ -447,7 +447,7 @@ onUnmounted(() => { | |||
| @click="goToDetailPage(props.row)" | |||
| @keydown.space.enter.prevent="goToDetailPage(props.row)" | |||
| > | |||
| <template v-if="props.row.image"> | |||
| <template v-if="props.row.image || props.row.isVideo"> | |||
There was a problem hiding this comment.
fix the issue where the hover preview for NFT tile icons would not show for video NFTs
ezra-sg
commented
Nov 13, 2023
| @@ -398,7 +398,12 @@ function setHoverPreviewVisibility(visible: boolean) { | |||
| &--preview { | |||
| max-height: 270px; | |||
|
|
|||
| #{$this}__image { | |||
| #{$this}__video-container { | |||
There was a problem hiding this comment.
fix grid blowout for tall videos
…t-logged' of github.com:telosnetwork/telos-wallet into 645-ipfs-nfts
ezra-sg
force-pushed
the
645-ipfs-nfts
branch
from
158852f to
2bad251
Compare
donnyquixotic
approved these changes
Nov 14, 2023
Viterbo
approved these changes
Nov 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #645
Includes work by @Viterbo from #667
Description
This PR enables viewing of IPFS NFTs. It also fixes a few issues:
Test scenarios
Hover working for video NFTs:
Recording.2023-11-13.165354.mp4
Checklist: