adding fallback when indexer is down to fetch nfts owners #671
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
✅ Deploy Preview for wallet-develop-mainnet ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for wallet-staging ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
…for-stale-nft-indexer-data
donnyquixotic
previously approved these changes
Nov 16, 2023
ezra-sg
reviewed
Nov 16, 2023
| @@ -383,6 +411,14 @@ export default abstract class EVMChainSettings implements ChainSettings { | |||
|
|
|||
| this.processNftContractsCalldata(response.contracts); | |||
| const shapedNftData = this.shapeNftRawData(shapedIndexerNftData, response.contracts); | |||
|
|
|||
| // if the owner does not comes from the indexer, let's set it | |||
| shapedNftData.forEach((nft) => { | |||
There was a problem hiding this comment.
this should only be set for erc721, which is why line 409 has a ternary like
owner: isErc1155 ? undefined : nftResponse.owner,
so here we should also only set owner if it's 1155
There was a problem hiding this comment.
Can we remove this forEach and just set it in the original mapping?
owner: isErc1155 ? account : nftResponse.owner,
There was a problem hiding this comment.
I updated to use owner: nftResponse.owner ?? account in mapping and remove forEach
ezra-sg
reviewed
Nov 16, 2023
| const getAccount = jest.fn().mockImplementation(() => null); | ||
| const getAccount = jest.fn().mockImplementation(() => ({ | ||
| authenticator: jest.fn().mockImplementation(() => ({ | ||
| web3Provider: jest.fn().mockImplementation(() => 'do you need to get deeper?'), |
|
when i click Demos, it kicks me back to the home page Recording.2023-11-16.162443.mp4 |
…indexer-data' of https://github.com/telosnetwork/telos-wallet into 659-implement-back-up-query-notification-for-stale-nft-indexer-data
donnyquixotic
previously approved these changes
Nov 16, 2023
Merged
donnyquixotic
approved these changes
Nov 18, 2023
donnyquixotic
deleted the
659-implement-back-up-query-notification-for-stale-nft-indexer-data
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #659
Description
This Pull Request addresses the issue of stale NFT indexer data. It implements a backup query mechanism and user notifications for cases where the indexer data is stale. The main enhancements include:
ownerOfandbalanceOfupdates when needed.These changes ensure that NFT ownership and quantity are accurately reflected, even when the indexer data is not up-to-date.
Test Scenarios
Currently, the indexer is up to date so I created a way to simulate the indexer is not healthy.
Videocapture
Owners-When-Indexer-Down.mp4
Checklist: