now all Authenticators handle cancel correctly #676
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for wallet-develop-mainnet ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for wallet-staging ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
donnyquixotic
approved these changes
Nov 16, 2023
Merged
donnyquixotic
suggested changes
Nov 17, 2023
There was a problem hiding this comment.
on OreId, If I cancel using the red 'x' on sign prompt I receive the correct error notification, if I click the blue text 'cancel' button, I receive the 'OOOPS' 'unknown error' and details are empty '{"error": {} }'. If possible (?), we may want to remove one of the redundant cancel options. If not, at least populating the error details for the second case.
on WalletConnect, canceling the transaction on 'send' in the MetaMask prompt results in the same 'OOOPs' but the details do indicate 'user rejected'.
…github.com/telosnetwork/telos-wallet into 573-change-cancel-icon-notification-type-2
donnyquixotic
approved these changes
Nov 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #573
Description
When the user cancels any transaction that generates an error that was handled with a error notification but now is a neutral notification. The responsible for verifying whether it's a cancellation or a different error is the Authenticator being used by the user. Therefore, the previous solution was only partially correct because it was not properly implemented across all Authenticators.
Test scenarios
Login using Telos Wallet and start and cancel most of the possible transactions you can do and see if all of them show the correct cancel message. See video
Grabacion.de.pantalla.desde.16-11-23.18.07.19.webm
Checklist: