ensuring supportedInterfaces property when quering nfts transactions #677
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for wallet-staging ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for wallet-develop-mainnet ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
donnyquixotic
approved these changes
Nov 17, 2023
ezra-sg
approved these changes
Nov 17, 2023
donnyquixotic
deleted the
668-some-nfts-are-not-shown-because-they-lack-an-attribute-2
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #668
Description
The History Store was pre-fetching the last transactions and that action generates to fetch and cache the metadata for all contracts without the fix of restoring the supportedInterfaces property. Once in the caché they never get restored. Therefore to see the changes you need to clean your local caché to fetch all contract metadata again. This time, the fetch process ends with the fix so it ends up saving locally the correct version of the metadata.
Test scenarios
Checklist: