Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#692 | Fix IPFS failure #695

Merged
merged 1 commit into from
Nov 28, 2023
Merged

Conversation

ezra-sg
Copy link
Contributor

@ezra-sg ezra-sg commented Nov 28, 2023

Fixes #692

Description

Currently, too many calls are being made to the IPFS gateway because the logic is incorrect; the IPFS gateway should only be hit during NFT construction when it is unclear if an image is media or not (if the URL for the image/video/audio has no extension, like .mp4, that is when we must hit the endpoint and determine the media type). Also this PR switches from using the cloudflare IPFS gateway to the Telos one.

Test scenarios

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have cleaned up the code in the areas my change touches
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings
  • I have removed any unnecessary console messages
  • I have included all english text to the translation file and/or created a new issue with the required translations for the currently supported languages
  • I have tested for mobile functionality and responsiveness
  • I have added appropriate test coverage

@ezra-sg ezra-sg linked an issue Nov 28, 2023 that may be closed by this pull request
Copy link

netlify bot commented Nov 28, 2023

Deploy Preview for wallet-staging ready!

Name Link
🔨 Latest commit 626bc1e
🔍 Latest deploy log https://app.netlify.com/sites/wallet-staging/deploys/656623694d2f7900085a6522
😎 Deploy Preview https://deploy-preview-695--wallet-staging.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Nov 28, 2023

Deploy Preview for wallet-develop-mainnet ready!

Name Link
🔨 Latest commit 626bc1e
🔍 Latest deploy log https://app.netlify.com/sites/wallet-develop-mainnet/deploys/65662369e7f2230008021a94
😎 Deploy Preview https://deploy-preview-695--wallet-develop-mainnet.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ezra-sg ezra-sg marked this pull request as ready for review November 28, 2023 17:31
@ezra-sg ezra-sg self-assigned this Nov 28, 2023
@donnyquixotic donnyquixotic merged commit a5b88ac into develop Nov 28, 2023
9 checks passed
@donnyquixotic donnyquixotic deleted the 692-optimize-the-nfts-inventory-page branch November 28, 2023 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Optimize the NFTs inventory page
3 participants