Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#660 | Unit tests fix #722

Merged
merged 6 commits into from
Dec 28, 2023
Merged

#660 | Unit tests fix #722

merged 6 commits into from
Dec 28, 2023

Conversation

ezra-sg
Copy link
Contributor

@ezra-sg ezra-sg commented Dec 28, 2023

Fixes #660

Description

This PR fixes some broken unit tests by updating how we use jest mocks

Test scenarios

  • check out the branch git fetch --all && git checkout 660-unit-test-fix
  • run tests yarn test
    • all tests should succeed

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have cleaned up the code in the areas my change touches
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings
  • I have removed any unnecessary console messages
  • I have included all english text to the translation file and/or created a new issue with the required translations for the currently supported languages
  • I have tested for mobile functionality and responsiveness
  • I have added appropriate test coverage

Copy link

netlify bot commented Dec 28, 2023

Deploy Preview for wallet-staging ready!

Name Link
🔨 Latest commit 0b4c477
🔍 Latest deploy log https://app.netlify.com/sites/wallet-staging/deploys/658db2891f6e0e0008d562e3
😎 Deploy Preview https://deploy-preview-722--wallet-staging.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Dec 28, 2023

Deploy Preview for wallet-develop-mainnet ready!

Name Link
🔨 Latest commit 0b4c477
🔍 Latest deploy log https://app.netlify.com/sites/wallet-develop-mainnet/deploys/658db289b1457b00081d6cea
😎 Deploy Preview https://deploy-preview-722--wallet-develop-mainnet.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ezra-sg ezra-sg self-assigned this Dec 28, 2023
@ezra-sg ezra-sg marked this pull request as ready for review December 28, 2023 00:35
@donnyquixotic donnyquixotic merged commit bd4bf8a into develop Dec 28, 2023
9 checks passed
@donnyquixotic donnyquixotic deleted the 660-unit-test-fix branch December 28, 2023 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Investigate failing unit tests
2 participants