Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Telos Cloud Login | Zero name input #759

Conversation

Viterbo
Copy link
Collaborator

@Viterbo Viterbo commented Jan 23, 2024

Fixes #753, #754, #755

Note: this PR includes #757 and #758

Description

This PR includes the following changes:

  • The flow changed from two steps to one step. Click on the Google button and you are in.
  • If the user has more than one account associated with the public key provided by Metakeep, a list of account is presented for the user to choose which one to use.
  • If is the first time that the user tries to identify, an account creation form will show up to let the user choose the name account.

Screenshots

telos-wallet-login--account-name-selection.webm
telos-wallet-login--multiple-accounts.webm

Test scenarios

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have cleaned up the code in the areas my change touches
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings
  • I have removed any unnecessary console messages
  • I have included all english text to the translation file and/or created a new issue with the required translations for the currently supported languages
  • I have tested for mobile functionality and responsiveness
  • I have added appropriate test coverage

@Viterbo Viterbo self-assigned this Jan 23, 2024
Copy link

netlify bot commented Jan 23, 2024

Deploy Preview for telos-cloud-wallet ready!

Name Link
🔨 Latest commit e378554
🔍 Latest deploy log https://app.netlify.com/sites/telos-cloud-wallet/deploys/65c1592bdd0dbb000948d345
😎 Deploy Preview https://deploy-preview-759--telos-cloud-wallet.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Viterbo Viterbo marked this pull request as ready for review January 24, 2024 14:32
Comment on lines +24 to +28
'telos': 'telos',
'telos-testnet': 'telos-testnet',
} : {
'telos': 'telos-evm',
'telos-testnet': 'telos-evm-testnet',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you get these values from the chain index files, e.g. NETWORK from src/antelope/chains/evm/telos-evm/index.ts instead of 'telos-evm'?

src/pages/home/LoginButtons.vue Outdated Show resolved Hide resolved
src/pages/home/LoginButtons.vue Outdated Show resolved Hide resolved
src/pages/home/LoginButtons.vue Outdated Show resolved Hide resolved
src/pages/home/LoginButtons.vue Outdated Show resolved Hide resolved
@ezra-sg

This comment was marked as resolved.

@ezra-sg

This comment was marked as resolved.

@ezra-sg

This comment was marked as resolved.

Copy link
Contributor

@ezra-sg ezra-sg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very nice!! works great, awesome stuff. i do have one remaining comment if you could update that, but approved either way

@Viterbo Viterbo mentioned this pull request Feb 8, 2024
10 tasks
@Viterbo Viterbo merged commit 4362270 into 752-epic--telos-cloud-login Feb 9, 2024
5 checks passed
@Viterbo Viterbo mentioned this pull request Feb 12, 2024
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants