Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: Wallet redirecting to TelosZero mainnet even when testnet is selected #824

Conversation

Viterbo
Copy link
Collaborator

@Viterbo Viterbo commented Jul 16, 2024

Fixes #823

Description

In this PR a refactor was made so that the native part stops depending on the environment variables and becomes completely dependent on the selected blockchain

Test scenarios

  • go to this link
  • Select Telos Zero
  • Login with any option
    • you should remain on the Native Mainnet
    • Test as many functionalities as you can (transfer, stake, etc)
    • All functionalities should work properly
    • Log out
  • Select Telos Zero (Testnet)
    • you should remain on the native testnet
    • repeat all what you did for the previous case
    • All functionalities should work properly also

@Viterbo Viterbo linked an issue Jul 16, 2024 that may be closed by this pull request
Copy link

netlify bot commented Jul 16, 2024

Deploy Preview for wallet-staging ready!

Name Link
🔨 Latest commit 7023df0
🔍 Latest deploy log https://app.netlify.com/sites/wallet-staging/deploys/6696bca874f6cd0008941aff
😎 Deploy Preview https://deploy-preview-824--wallet-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jul 16, 2024

Deploy Preview for wallet-develop-mainnet ready!

Name Link
🔨 Latest commit 7023df0
🔍 Latest deploy log https://app.netlify.com/sites/wallet-develop-mainnet/deploys/6696bca8f131f100084955e1
😎 Deploy Preview https://deploy-preview-824--wallet-develop-mainnet.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Viterbo Viterbo self-assigned this Jul 16, 2024
@Viterbo Viterbo marked this pull request as ready for review July 16, 2024 16:04
@Viterbo Viterbo changed the title 823 wallet redirecting to teloszero mainnet even when testnet is selected Bugfix: Wallet redirecting to TelosZero mainnet even when testnet is selected Jul 16, 2024
@rozzaswap rozzaswap merged commit 253ca88 into develop Jul 25, 2024
9 checks passed
@pmjanus pmjanus deleted the 823-wallet-redirecting-to-teloszero-mainnet-even-when-testnet-is-selected branch July 29, 2024 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wallet redirecting to TelosZero mainnet even when testnet is selected
2 participants