auto-close dialog when no access to the camera #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for wallet-staging ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for wallet-testnet ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
ezra-sg
reviewed
Jan 2, 2023
| watch: { | ||
| showDlg() { | ||
| if (this.showDlg) { | ||
| setTimeout(async () => { this.activateQR = true; }, 250); |
There was a problem hiding this comment.
arrow function doesn't need to be async as it has no async code
ezra-sg
approved these changes
Jan 2, 2023
donnyquixotic
approved these changes
Jan 2, 2023
karynemayer
suggested changes
Jan 3, 2023
Viterbo
force-pushed
the
29-lingering-scan-access-dialog
branch
from
b60b481 to
ea6a2aa
Compare
donnyquixotic
approved these changes
Jan 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #29
Description
The dialog did not react to the denial of access to the camera remaining open and useless. The user had to refresh to come back to the balances page. This PR fixes that idle behavior by closing the dialog when non-access to the camera is detected, showing to the user an appropriate notification message.
Test notes
To test this new behavior you need to follow these steps:
##screenshots
Checklist: