Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong parameters in the query for Block page, Transactions tab #839

Closed
2 tasks done
Viterbo opened this issue Aug 28, 2024 · 0 comments · Fixed by #841
Closed
2 tasks done

Wrong parameters in the query for Block page, Transactions tab #839

Viterbo opened this issue Aug 28, 2024 · 0 comments · Fixed by #841
Assignees
@Viterbo

Comments

@Viterbo
Copy link
Collaborator

Viterbo commented Aug 28, 2024 •
edited
Loading

Description

Currently, the Block page in the Transactions tab uses the wrong set of parameters.

wrong:
https://api.teloscan.io/v1/transactions?limit=50&key=3615177&sort=desc&includePagination=true&includeAbi=true&startBlock=249101437&endBlock=249101437

correct:
https://api.teloscan.io/v1/transactions?limit=50&key=3615177&sort=desc&includePagination=true&includeAbi=true&block=249101437

Tasks

  • replace startBlock for simply block
  • remove endBlock parameter

PR here
@Viterbo Viterbo self-assigned this Aug 28, 2024
@Viterbo Viterbo changed the title Wrong parameters in Transactions query Wrong parameters in the query for Block page, Transactions tab Aug 28, 2024
@Viterbo Viterbo mentioned this issue Aug 28, 2024
Merged
pmjanus added a commit that referenced this issue Aug 28, 2024
@pmjanus
Merge pull request #840 from telosnetwork/839-wrong-parameters-in-tra…
4104973 
…nsactions-query

#839 | Query parameters for transactions for a block were fixed
@pmjanus pmjanus mentioned this issue Aug 28, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Viterbo Viterbo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Release Candidate telosnetwork/teloscan
1 participant
@Viterbo