Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#127 | Update linting rules #317

Merged
merged 56 commits into from
Jan 23, 2023
Merged

#127 | Update linting rules #317

merged 56 commits into from
Jan 23, 2023

Conversation

ezra-sg
Copy link
Contributor

@ezra-sg ezra-sg commented Jan 19, 2023

Fixes #127

Description

This PR updates linting rules

Test scenarios

generally click through the site and verify that it works. There are no functional changes whatsoever; all functionality should be the same as in dev

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have cleaned up the code in the areas my change touches
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings
  • I have removed any unnecessary console messages

@netlify
Copy link

netlify bot commented Jan 19, 2023

Deploy Preview for dev-mainnet-teloscan ready!

Name Link
🔨 Latest commit 10a5cf1
🔍 Latest deploy log https://app.netlify.com/sites/dev-mainnet-teloscan/deploys/63cec2adcd085b00094cd611
😎 Deploy Preview https://deploy-preview-317--dev-mainnet-teloscan.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Jan 19, 2023

Deploy Preview for teloscan-stage ready!

Name Link
🔨 Latest commit 10a5cf1
🔍 Latest deploy log https://app.netlify.com/sites/teloscan-stage/deploys/63cec2ad9f69210008ced1c5
😎 Deploy Preview https://deploy-preview-317--teloscan-stage.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@ezra-sg ezra-sg changed the title #127 | Update linting rules #127 | Update linting rules WIP Jan 19, 2023
@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Jan 19, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 10a5cf1
Status: ✅  Deploy successful!
Preview URL: https://6535846a.teloscan.pages.dev
Branch Preview URL: https://127-linting.teloscan.pages.dev

View logs

@Viterbo Viterbo dismissed stale reviews from donnyquixotic and themself via 6195cd6 January 21, 2023 21:35
Viterbo
Viterbo previously approved these changes Jan 21, 2023
Copy link
Collaborator

@Viterbo Viterbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did solve all conflicts and pushed the commits containing the final changes:
226fcfe and 6195cd6.

@Viterbo Viterbo merged commit 9c628f6 into dev Jan 23, 2023
@donnyquixotic donnyquixotic deleted the 127-linting branch February 17, 2023 00:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

update linting rules
3 participants