-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#380 | CSV Export #517
#380 | CSV Export #517
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent work!
Just a few minor changes, all related to the word "deposit" being translated into Latin-rooted languages.
✅ Deploy Preview for testnet-teloscan ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
I have a couple of changes I'd like to make to the export functionality: Please adjust the width of the input boxes for selecting the export type (Transactions, Internal Transactions, Token Transfers, etc.). They currently appear too wide, and I'd like them to be narrower to take up less horizontal space. One calendar control should be used for selecting the start date This will allow users to choose the start and end dates independently,. |
We are missing the CSV Export option on the More section of the Navbar. (not on Advanced as it says on the PR). |
@Viterbo Block number filtering doesn't seem to be working properly for me. I filtered from block 277737852 to 297737852 After downloading the csv, blocks are shown from block 218418469 to 289651935 |
@Viterbo the block filter fix has been deployed. |
@Viterbo currently investigating why date filtering now not working: |
Waiting for @tomtomcrypto to take a look at https://github.com/telosnetwork/teloscan-indexer/issues/255 |
Tested with ERC transactions and date range. Ready for final test and merge |
There are issues with date and block validations: Nitpick since who would input negative block - Blocks: |
TODO discuss adding CSV export endpoint / hcaptcha validation endpoint
Fixes #380
Description
This PR adds the ability to export transactions and token transfers as CSV
Test scenarios
git fetch --all && git checkout 380-csv-export && yarn install && yarn dev
Transactions
0x...3c3c
, select Transactions and then you can enter start block320792430
to end block320792434
to get one tx)Checklist: