Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#641 | search bar more intitive #642

Merged
merged 2 commits into from
Apr 3, 2024

Conversation

Viterbo
Copy link
Collaborator

@Viterbo Viterbo commented Apr 2, 2024

Fixes #641

Description

This PR eliminates the clear button from the search bar input text and inits place the search action button was placed.

Test scenarios

  • go this link
  • write something on the search bar
    • a cross icon should not appear anymore, in its place should appear a search icon
  • then click the search button
    • the search should be performed

Screenshots

image
image

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have cleaned up the code in the areas my change touches
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings
  • I have removed any unnecessary console messages
  • I have included all english text to the translation file and/or created a new issue with the required translations for the currently supported languages
  • I have tested for mobile functionality and responsiveness
  • I have added appropriate test coverage
  • I have updated relevant documentation and/or opened a separate issue to cover the updates (Issue URL: )

@Viterbo Viterbo self-assigned this Apr 2, 2024
Copy link

netlify bot commented Apr 2, 2024

Deploy Preview for teloscan-redesign ready!

Name Link
🔨 Latest commit 7573118
🔍 Latest deploy log https://app.netlify.com/sites/teloscan-redesign/deploys/660c700a77c481000740debf
😎 Deploy Preview https://deploy-preview-642--teloscan-redesign.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Apr 2, 2024

Deploy Preview for teloscan-redesign-mainnet ready!

Name Link
🔨 Latest commit 7573118
🔍 Latest deploy log https://app.netlify.com/sites/teloscan-redesign-mainnet/deploys/660c700a6d05f20008ccb42a
😎 Deploy Preview https://deploy-preview-642--teloscan-redesign-mainnet.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@pmjanus pmjanus merged commit f9516bc into epic-redesign Apr 3, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants