Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Production #730

Merged
merged 2 commits into from
May 1, 2024
Merged

Update Production #730

merged 2 commits into from
May 1, 2024

Conversation

pmjanus
Copy link
Contributor

@pmjanus pmjanus commented Apr 30, 2024

Fixes

Fixes #726

Description

  • shortens Txn Fee Header

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have cleaned up the code in the areas my change touches
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings
  • I have removed any unnecessary console messages
  • I have included all english text to the translation file and/or created a new issue with the required translations for the currently supported languages
  • I have tested for mobile functionality and responsiveness
  • I have added appropriate test coverage
  • I have updated relevant documentation and/or opened a separate issue to cover the updates (Issue URL: )

Copy link

netlify bot commented Apr 30, 2024

Deploy Preview for teloscan ready!

Name Link
🔨 Latest commit dc1f395
🔍 Latest deploy log https://app.netlify.com/sites/teloscan/deploys/6630e5d92ab211000842efb5
😎 Deploy Preview https://deploy-preview-730--teloscan.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Apr 30, 2024

Deploy Preview for testnet-teloscan ready!

Name Link
🔨 Latest commit dc1f395
🔍 Latest deploy log https://app.netlify.com/sites/testnet-teloscan/deploys/6630e5d92ba2530008548d18
😎 Deploy Preview https://deploy-preview-730--testnet-teloscan.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Apr 30, 2024

Deploy Preview for dev-mainnet-teloscan ready!

Name Link
🔨 Latest commit dc1f395
🔍 Latest deploy log https://app.netlify.com/sites/dev-mainnet-teloscan/deploys/6630e5d9660f0a0008516627
😎 Deploy Preview https://deploy-preview-730--dev-mainnet-teloscan.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Apr 30, 2024

Deploy Preview for teloscan-stage ready!

Name Link
🔨 Latest commit dc1f395
🔍 Latest deploy log https://app.netlify.com/sites/teloscan-stage/deploys/6630e5d92240c20008337847
😎 Deploy Preview https://deploy-preview-730--teloscan-stage.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@rozzaswap
Copy link
Contributor

rozzaswap commented May 1, 2024

@Viterbo decimal places is still defaulting to the wrong version (Second part of #726)

image

https://deploy-preview-730--teloscan-stage.netlify.app/address/0xa9991E4daA44922D00a78B6D986cDf628d46C4DD

@rozzaswap
Copy link
Contributor

rozzaswap commented May 1, 2024

Copy link
Contributor

@rozzaswap rozzaswap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't seem to contain fixes to all linked issues

@rozzaswap rozzaswap marked this pull request as ready for review May 1, 2024 11:44
@rozzaswap rozzaswap merged commit dc4587b into master May 1, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename tx fee column header
3 participants