Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#740 | add confirmation step before downloading image from nft #745

Merged
merged 1 commit into from
May 15, 2024

Conversation

Viterbo
Copy link
Collaborator

@Viterbo Viterbo commented May 14, 2024

Fixes #740

Description

In the cases where the image of the NFT is embedded, there is no way to show it in a different browser tab. So clicking on it downloads the image. This PR adds a confirmation dialog before actually downloading the image.

Test scenarios

  • go to this link
  • scroll to find the NFT named lock # 48
  • click on the image
    • you should see a popup confirmation dialog that disappears after 5 seconds
    • only if you confirm, the images downloads

image

Copy link

netlify bot commented May 14, 2024

Deploy Preview for testnet-teloscan ready!

Name Link
🔨 Latest commit 09c5672
🔍 Latest deploy log https://app.netlify.com/sites/testnet-teloscan/deploys/6643df7754277500086eef40
😎 Deploy Preview https://deploy-preview-745--testnet-teloscan.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented May 14, 2024

Deploy Preview for teloscan-stage ready!

Name Link
🔨 Latest commit 09c5672
🔍 Latest deploy log https://app.netlify.com/sites/teloscan-stage/deploys/6643df77d03c52000805ca05
😎 Deploy Preview https://deploy-preview-745--teloscan-stage.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented May 14, 2024

Deploy Preview for dev-mainnet-teloscan ready!

Name Link
🔨 Latest commit 09c5672
🔍 Latest deploy log https://app.netlify.com/sites/dev-mainnet-teloscan/deploys/6643df77d2d7d2000818141f
😎 Deploy Preview https://deploy-preview-745--dev-mainnet-teloscan.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@pmjanus pmjanus merged commit 6c18b69 into dev May 15, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants