Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#774 | The contract tab keeps selected after the user logs in #774

Conversation

Viterbo
Copy link
Collaborator

@Viterbo Viterbo commented Jun 13, 2024

Fixes #640

Description

This PR adds a new URL variable to reflect the subtab the user is in. If the user logs in or out, the component resets and takes the selected tab from that variable, keeping the same tab chosen afterward.

Test scenarios

  • Go to this link
  • Select "write" tab
  • Connect wallet (log in)
    • it should not change the selected tab

image
image

@Viterbo Viterbo self-assigned this Jun 13, 2024
Copy link

netlify bot commented Jun 13, 2024

Deploy Preview for dev-mainnet-teloscan ready!

Name Link
🔨 Latest commit 3db5d20
🔍 Latest deploy log https://app.netlify.com/sites/dev-mainnet-teloscan/deploys/666af37fa739a70009d5ccd0
😎 Deploy Preview https://deploy-preview-774--dev-mainnet-teloscan.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jun 13, 2024

Deploy Preview for testnet-teloscan ready!

Name Link
🔨 Latest commit 3db5d20
🔍 Latest deploy log https://app.netlify.com/sites/testnet-teloscan/deploys/666af37e92bcff0008ed1378
😎 Deploy Preview https://deploy-preview-774--testnet-teloscan.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jun 13, 2024

Deploy Preview for teloscan-stage ready!

Name Link
🔨 Latest commit 3db5d20
🔍 Latest deploy log https://app.netlify.com/sites/teloscan-stage/deploys/666af37f97987c00082c5741
😎 Deploy Preview https://deploy-preview-774--teloscan-stage.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Viterbo Viterbo changed the title The contract tab keeps selected after the user logs in #774 | The contract tab keeps selected after the user logs in Jun 14, 2024
@rozzaswap rozzaswap merged commit f7e9ae1 into dev Jun 14, 2024
13 checks passed
@rozzaswap rozzaswap deleted the 640-on-write-contract-tab-changes-to-code-tab-after-logging-in-or-out branch June 14, 2024 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants