Migrate to biny #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
telvarost
reviewed
Sep 19, 2024
| @@ -14,7 +14,7 @@ maven_group = pl.telvarost | |||
| archives_base_name = mojangfixstationapi | |||
|
|
|||
| # Dependencies | |||
| stapi_version=2.0-alpha.2 | |||
| stapi_version=2.0-alpha.2.3 | |||
There was a problem hiding this comment.
Isn't StationAPI 2.3 broken in prod right now? Shouldn't this be 2.1?
There was a problem hiding this comment.
It doesn't make a difference, as the things changed in 2.3 versus 2.1 are not touched by this mod, so pretty much the only difference is the runtime version of stationapi as all API things remain the same.
There was a problem hiding this comment.
and in dev it works fine
There was a problem hiding this comment.
I usually like to set it to whatever, players will actually experience. So I will probably revert it back to 2.1 until StationAPI stabilizes
There was a problem hiding this comment.
Sure, it doesn't make much of a difference to me
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously was using barn, since biny is a fork of barn it wasn't too intrusive.