Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hybrid improvements #198

Merged
merged 9 commits into from
Feb 7, 2025
Merged

Hybrid improvements #198

merged 9 commits into from
Feb 7, 2025

Conversation

Jayko001
Copy link
Contributor

@Jayko001 Jayko001 commented Feb 7, 2025

No description provided.

@Jayko001 Jayko001 requested a review from ChuckHend as a code owner February 7, 2025 05:33
ChuckHend
ChuckHend requested changes Feb 7, 2025
View reviewed changes
Copy link
Member

@ChuckHend ChuckHend left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a test that is using the utility function hybrid_search_with_retry() you created. Remove the vectorize.hybrid_search() call that is in the test_scheduled_job() test.

@Jayko001 Jayko001 requested a review from ChuckHend February 7, 2025 19:12
@ChuckHend ChuckHend merged commit 11bb77e into main Feb 7, 2025
9 checks passed
@ChuckHend ChuckHend deleted the hybrid_improvements branch February 7, 2025 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChuckHend ChuckHend ChuckHend approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Jayko001 @ChuckHend