Skip to content
This repository has been archived by the owner on Dec 5, 2023. It is now read-only.

Add connection string info for app user #216

Merged
merged 2 commits into from
Aug 21, 2023
Merged

Add connection string info for app user #216

merged 2 commits into from
Aug 21, 2023

Conversation

nhudson
Copy link
Contributor

@nhudson nhudson commented Aug 21, 2023 •
edited
Loading

This PR changes how we send back connection string information to the control-plane. This will include the connection string info for both the postgres and app users.

  • Added Box to the AwsErr trait to keep clippy from warning about large variants
  • Reworked how we extract the secret data to better handle multiple secrets if we wish to add more in the future.
  • Added helper functions to better handle data type conversion from the Kubernetes Secret to create ConnectionInfo

fixes: TEM-1389

@nhudson nhudson self-assigned this Aug 21, 2023
sjmiller609
sjmiller609 suggested changes Aug 21, 2023
View reviewed changes
conductor/src/lib.rs Show resolved Hide resolved
conductor/src/types.rs Outdated Show resolved Hide resolved
@nhudson nhudson merged commit f587b06 into main Aug 21, 2023
7 checks passed
@nhudson nhudson deleted the nhudson/TEM-1389 branch August 21, 2023 22:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sjmiller609 sjmiller609 sjmiller609 approved these changes

@ianstanton ianstanton Awaiting requested review from ianstanton ianstanton is a code owner

@ChuckHend ChuckHend Awaiting requested review from ChuckHend ChuckHend is a code owner

Assignees

@nhudson nhudson

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nhudson @sjmiller609