Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deproxy client isn't closed on errors (probably RSTs) if "interface" argument isn't passed #492

Closed
voodam opened this issue Jul 13, 2023 · 1 comment
Labels
bug Something isn't working
Milestone

Comments

@voodam
Copy link
Contributor

voodam commented Jul 13, 2023

Flow of the error:

  1. TempestaTest.__create_client, if client.get("interface", False): here we create alias interface and route, then pass IP to __create_client_deproxy. But, even if create_interface and create_route are disabled and only IP is passed, error is gone. Thus, error can be only in __create_client_deproxy.

  2. Passed IP is used only in TlsClient.run_start:

         if self.bind_addr:
             self.bind((self.bind_addr, 0))

So the root cause is bind. In my test even binding to random address (without creating interface and route) makes self.assertTrue(client.wait_for_connection_close(self.timeout)) pass.

Result: all commented parts in t_frang/test_ip_block.py should be uncommented and pass.
Blocker: tempesta-tech/tempesta#1751, wait when all tests with this issue in reason will be fixed.

@krizhanovsky krizhanovsky added the bug Something isn't working label Jul 13, 2023
@krizhanovsky krizhanovsky added this to the 1.0 - GA milestone Jul 13, 2023
@voodam
Copy link
Contributor Author

voodam commented Sep 10, 2023

Fixed in #486.

@voodam voodam closed this as completed Sep 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants