Fix and enable test accoring to #1716 #486
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
voodam
commented
Jul 7, 2023
voodam
commented
- burst messages can exceed the limit x2, so we need to assert range
- connection_* frang limits (will be renamed to tcp_connection_*) affect any connection (both TLS and non TLS), so rework FrangConnectionTlsAndNonTlsRateBurst
- rename testcases for better readability
voodam
force-pushed
the
am-1716-tls-conn-burst
branch
3 times, most recently
from
dad46f9 to
27efa75
Compare
voodam
force-pushed
the
am-1716-tls-conn-burst
branch
from
4fc8c19 to
41615ba
Compare
voodam
requested review from
EvgeniiMekhanik,
krizhanovsky and
RomanBelozerov
and removed request for
EvgeniiMekhanik
|
It seems we need to merge broken tests because of config directives renaming. We can't redefine both branches of tempesta and tempesta-tests for now, as I know. |
voodam
force-pushed
the
am-1716-tls-conn-burst
branch
from
41615ba to
3bc4f01
Compare
RomanBelozerov
requested changes
Jul 11, 2023
There was a problem hiding this comment.
FAIL: test_connection_burst (t_frang.test_connection_rate_burst.FrangTls)
----------------------------------------------------------------------
Traceback (most recent call last):
File "/mnt/other/tempesta-test/t_frang/test_connection_rate_burst.py", line 131, in test_connection_burst
self._base_burst_scenario(connections=11)
File "/mnt/other/tempesta-test/t_frang/test_connection_rate_burst.py", line 92, in _base_burst_scenario
self.assertConnReseted(curl.last_response)
File "/mnt/other/tempesta-test/t_frang/frang_test_case.py", line 108, in assertConnReseted
self.assertEqual(r.status, 0)
AssertionError: 200 != 0FAIL: test_connection_burst (t_frang.test_connection_rate_burst.FrangTcp)
----------------------------------------------------------------------
Traceback (most recent call last):
File "/mnt/other/tempesta-test/t_frang/test_connection_rate_burst.py", line 131, in test_connection_burst
self._base_burst_scenario(connections=11)
File "/mnt/other/tempesta-test/t_frang/test_connection_rate_burst.py", line 89, in _base_burst_scenario
self.assertFrangWarning(warning=self.burst_warning, expected=warning_count)
File "/mnt/other/tempesta-test/t_frang/frang_test_case.py", line 119, in assertFrangWarning
self.assertTrue(test_value, self.assert_msg.format(exp=expected, got=warning_count))
AssertionError: False is not true : Expected nums of warnings in `journalctl`: range(1, 6), but got 10
voodam
force-pushed
the
am-1716-tls-conn-burst
branch
2 times, most recently
from
1e3b4b2 to
782d55e
Compare
|
The tests reworked significantly. |
voodam
force-pushed
the
am-1716-tls-conn-burst
branch
8 times, most recently
from
e38a0fb to
7052565
Compare
voodam
force-pushed
the
am-1716-tls-conn-burst
branch
from
7052565 to
9db139a
Compare
voodam
force-pushed
the
am-1716-tls-conn-burst
branch
from
9db139a to
9f31bde
Compare
voodam
force-pushed
the
am-1716-tls-conn-burst
branch
3 times, most recently
from
b218856 to
99cbbcb
Compare
- Client IP is bound to client by default - Proper IPs are set now in many tests
voodam
force-pushed
the
am-1716-tls-conn-burst
branch
from
62a21e8 to
5a1def0
Compare
…due to active polling used inside.
- It created several times in Frang testcases before - It called sysctl even if message_cost is disabled already - It restored the original message_cost value in random time (when destuctor called) Some that cases (I don't know what exactly and how) led to the behaviour when messages was suppressed anyway.
IP confusling: - regression.test_invalid.TestInvalidResponse.test_204_with_body - regression.test_invalid.TestInvalidResponse.test_no_crlf_before_body - tcp_connection.test_connection_close.CloseConnection.test Flacking ones: - t_frang.test_request_rate_burst.FrangRequestBurstTestCase.test_two_clients_one_ip - t_frang.test_request_rate_burst.FrangRequestBurstTestCase.test_two_clients_two_ip - t_frang.test_request_rate_burst.FrangRequestRateTestCase.test_two_clients_one_ip - t_frang.test_request_rate_burst.FrangRequestRateTestCase.test_two_clients_two_ip
- Add getsockname info logging - Make output more uniform
voodam
force-pushed
the
am-1716-tls-conn-burst
branch
4 times, most recently
from
6a89483 to
1b28904
Compare
RomanBelozerov
requested changes
Oct 5, 2023
RomanBelozerov
approved these changes
Oct 5, 2023
Add --from-failstr parameter, example of usage: ./run_tests.py -F 'FAIL: test_connection_burst (t_frang.test_connection_rate_burst.FrangTls)'
- Main motivation wait_until moved under the hood of warn_count() (renamed to find()). This leads to changing signature - we need predicate to have valid poll condition. - Refactoring: renamed some arguments and methods. - Removed unused and unnecessary methods.
voodam
force-pushed
the
am-1716-tls-conn-burst
branch
from
aae893b to
16752be
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.