Forwarded HTTP header #1350 tests #219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
const-t
commented
May 17, 2022
const-t
commented
- Added tests for correctness of choosing host and accuracy of parsing.
- Added tests for correctness of choosing host and accuracy of parsing.
krizhanovsky
approved these changes
May 25, 2022
There was a problem hiding this comment.
Looks good to merge. Thank you for the contribution!
Once the copyrights are updated, I'll merge the code, probably with masking the tests in tests_disabled.json before tempesta-tech/tempesta#1629 is merged.
forwarding/test_forwarded_hdr.py
Outdated
|
|
||
| class SingleTest(object): | ||
| def test(self): | ||
| self._test() |
There was a problem hiding this comment.
Please consider this comment #221 (comment) - we'll need a unified helper for this.
There was a problem hiding this comment.
Please consider this comment #221 (comment) - we'll need a unified helper for this.
ok, I am waiting for helper and will update my tests.
|
Also need to update |
krizhanovsky
approved these changes
Jun 24, 2022
krizhanovsky
requested review from
nickzaev and
pale-emperor
and removed request for
nickzaev
|
Code looks well |
-Added case to verify host empty square brackets
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.