reworked long body tests #304

RomanBelozerov · 2022-09-12T13:44:32Z

long_body tests is separated to t_long_body, t_wrong_body_length and t_stress.

I reworked old tests for new framework, and also added tests:

for values 'Content-Length' header: negative, decimal, empty, longer.
stress tests for http/https/h2 requests.
tests for big data in http/https/h2 request/response.

const-t

Tests looks good, but need some changes in request parsing and error handling

long_body/test_request_wrong_length.py

framework/deproxy_client.py

const-t · 2022-10-11T14:01:50Z

Need to develop tests to verify tempesta-tech/tempesta#1418. Tests must include:

Sending non-chunked response to HTTP1 client which has body length over 16384 bytes.
Sending non-chunked response to HTTP2 client which has body length over 16384 bytes.
Sending chunked response to HTTP1 client which has multiple chunks with length over 16384 bytes.
Sending chunked response to HTTP2 client which has multiple chunks with length over 16384 bytes.

Also need to make version of each test with enabled tempesta caching. In case of chunked, response returned from cache must contain Content-Length, instead of chunked body.

…nd big data for client and server deproxy. Added disabling start clients in start_all_services method.

…response.

b3b

Got errors when running with the default config.

./run_tests.py t_long_body t_wrong_body_length t_stress

======================================================================
FAIL: test_http (t_long_body.test_long_request.LongBodyInRequest)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/root/tempesta-test2/t_long_body/test_long_request.py", line 158, in test_http
    self._test(
  File "/root/tempesta-test2/t_long_body/test_long_request.py", line 134, in _test
    client.send_request(
  File "/root/tempesta-test2/framework/deproxy_client.py", line 319, in send_request
    assert curr_responses + 1 == len(self.responses), "Deproxy client has lost response."
AssertionError: Deproxy client has lost response.

======================================================================
FAIL: test_https (t_long_body.test_long_request.LongBodyInRequest)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/root/tempesta-test2/t_long_body/test_long_request.py", line 163, in test_https
    self._test(
  File "/root/tempesta-test2/t_long_body/test_long_request.py", line 134, in _test
    client.send_request(
  File "/root/tempesta-test2/framework/deproxy_client.py", line 319, in send_request
    assert curr_responses + 1 == len(self.responses), "Deproxy client has lost response."
AssertionError: Deproxy client has lost response.

======================================================================
FAIL: test_many_big_chunks_in_request_http (t_long_body.test_long_request.LongBodyInRequest)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/root/tempesta-test2/t_long_body/test_long_request.py", line 185, in test_many_big_chunks_in_request_http
    self._test(
  File "/root/tempesta-test2/t_long_body/test_long_request.py", line 134, in _test
    client.send_request(
  File "/root/tempesta-test2/framework/deproxy_client.py", line 319, in send_request
    assert curr_responses + 1 == len(self.responses), "Deproxy client has lost response."
AssertionError: Deproxy client has lost response.

======================================================================
FAIL: test_many_big_chunks_in_request_https (t_long_body.test_long_request.LongBodyInRequest)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/root/tempesta-test2/t_long_body/test_long_request.py", line 192, in test_many_big_chunks_in_request_https
    self._test(
  File "/root/tempesta-test2/t_long_body/test_long_request.py", line 134, in _test
    client.send_request(
  File "/root/tempesta-test2/framework/deproxy_client.py", line 319, in send_request
    assert curr_responses + 1 == len(self.responses), "Deproxy client has lost response."
AssertionError: Deproxy client has lost response.

======================================================================
FAIL: test_one_big_chunk_in_request_http (t_long_body.test_long_request.LongBodyInRequest)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/root/tempesta-test2/t_long_body/test_long_request.py", line 171, in test_one_big_chunk_in_request_http
    self._test(
  File "/root/tempesta-test2/t_long_body/test_long_request.py", line 134, in _test
    client.send_request(
  File "/root/tempesta-test2/framework/deproxy_client.py", line 319, in send_request
    assert curr_responses + 1 == len(self.responses), "Deproxy client has lost response."
AssertionError: Deproxy client has lost response.

======================================================================
FAIL: test_one_big_chunk_in_request_https (t_long_body.test_long_request.LongBodyInRequest)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/root/tempesta-test2/t_long_body/test_long_request.py", line 178, in test_one_big_chunk_in_request_https
    self._test(
  File "/root/tempesta-test2/t_long_body/test_long_request.py", line 134, in _test
    client.send_request(
  File "/root/tempesta-test2/framework/deproxy_client.py", line 319, in send_request
    assert curr_responses + 1 == len(self.responses), "Deproxy client has lost response."
AssertionError: Deproxy client has lost response.

----------------------------------------------------------------------
Ran 77 tests in 499.843s

FAILED (failures=6, skipped=11)

b3b · 2022-11-01T14:04:55Z

t_long_body tests take up a lot of memory. Is this the expected behavior?
On machine with low memory test can't finish:

        Waiting for Server node
        Attempt to access node
Node Server is available
        Waiting for Tempesta node
        Attempt to access node
Node Tempesta is available
        Waiting for Server node
        Attempt to access node
Node Server is available
        Waiting for Tempesta node
        Attempt to access node
Node Tempesta is available
        Starting Nginx on nginx
        Starting TempestaFW on node1.tp
Running deproxy
Running deproxy server manager
        Starting deproxy client
Request parsing is running.
Request parsing is complete.
Error while polling:    Deproxy: Client: The operation did not complete (write) (_ssl.c:2396) (SSLWantWriteError: The operation did not complete (write) (_ssl.c:2396))
Finished deproxy manager
        Teardown
Not started
Not started
        Stopping TempestaFW on node1.tp
        Stopping Nginx on nginx
        Removing Nginx config for nginx
Stopping deproxy
Removing interfaces
FAIL
test_one_big_chunk_in_request_http (t_long_body.test_long_request.LongBodyInRequest) ...        Init test case...
        Waiting for Server node
        Attempt to access node
Node Server is available
        Waiting for Tempesta node
        Attempt to access node
Node Tempesta is available
        Waiting for Server node
        Attempt to access node
Node Server is available
        Waiting for Tempesta node
        Attempt to access node
Node Tempesta is available
        Starting Nginx on nginx
        Starting TempestaFW on node1.tp
Running deproxy
Running deproxy server manager
        Starting deproxy client
Request parsing is running.
Killed

b3b · 2022-11-10T12:37:04Z

Checked how t_long_body.test_long_request.LongBodyInRequest performs on my setup:

long_body_size=500, no errors
long_body_size=2000, сurl can't perform request: curl: option --data-binary: out of memory
long_body_size=900, sometimes OK and sometimes : curl: (55) OpenSSL SSL_write: Connection reset by peer, errno 104
dmesg: Cannot grow HTTP data string

…n tests_disabled.json

RomanBelozerov · 2022-11-14T08:16:27Z

Checked how t_long_body.test_long_request.LongBodyInRequest performs on my setup:

* long_body_size=500, no errors

* long_body_size=2000, сurl can't perform request: `curl: option --data-binary: out of memory`

* long_body_size=900, sometimes OK and sometimes : `curl: (55) OpenSSL SSL_write: Connection reset by peer, errno 104`
  dmesg: `Cannot grow HTTP data string`

I checked this branch on CI machine and it works with 500 MB body.

b3b

LGTM

const-t

LGTM

RomanBelozerov requested a review from krizhanovsky September 12, 2022 13:49

RomanBelozerov mentioned this pull request Sep 12, 2022

Test explicit body length specification for methdos having body #287

Open

krizhanovsky requested review from const-t and removed request for krizhanovsky September 12, 2022 14:25

const-t requested changes Sep 15, 2022

View reviewed changes

long_body/test_request_wrong_length.py Outdated Show resolved Hide resolved

framework/deproxy_client.py Outdated Show resolved Hide resolved

framework/deproxy_client.py Outdated Show resolved Hide resolved

krizhanovsky requested a review from b3b September 16, 2022 16:05

RomanBelozerov force-pushed the rb-56-redesigned-long-body-tests branch from edd7b6c to c5a9e67 Compare October 5, 2022 09:51

RomanBelozerov force-pushed the rb-56-redesigned-long-body-tests branch from c5a9e67 to 49f4df5 Compare October 21, 2022 15:51

RomanBelozerov mentioned this pull request Oct 24, 2022

add tests for headers in h2 request #344

Closed

6 tasks

RomanBelozerov added 6 commits October 27, 2022 18:11

removed long_body directory

b5a7b03

updated send_request method for work with deproxy_h2 client. Added se…

c81ce8a

…nd big data for client and server deproxy. Added disabling start clients in start_all_services method.

add stress tests for big data in request.

119c5fa

added tests for long body in request/response.

3b8881e

added tests for wrong body length (Content-Length header) in request/…

693fae8

…response.

disabled non-working tests and enabled working tests

1ff9428

RomanBelozerov force-pushed the rb-56-redesigned-long-body-tests branch from 49f4df5 to 1ff9428 Compare October 28, 2022 09:58

RomanBelozerov requested a review from const-t October 28, 2022 10:08

all files are formatted black and isort.

f780e48

b3b suggested changes Nov 1, 2022

View reviewed changes

const-t mentioned this pull request Nov 8, 2022

long_body - tests fail tempesta-tech/tempesta#1659

Closed

RomanBelozerov added 2 commits November 8, 2022 18:48

deproxy client replaced by curl. Deproxy uses a lot of resources.

fea1f0b

enabled tests for #1418 and #1710

cc851b2

added reason for test_response_wrong_length.ResponseSmallBodyLength i…

dbf0dcf

…n tests_disabled.json

RomanBelozerov requested a review from b3b November 14, 2022 08:16

b3b approved these changes Nov 14, 2022

View reviewed changes

Merge branch 'master' into rb-56-redesigned-long-body-tests

92cd62f

fix warning in tests_disabled.json

a6dcbc6

const-t approved these changes Nov 14, 2022

View reviewed changes

RomanBelozerov merged commit a58db54 into master Nov 14, 2022

RomanBelozerov deleted the rb-56-redesigned-long-body-tests branch November 14, 2022 11:31

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

reworked long body tests #304

reworked long body tests #304

RomanBelozerov commented Sep 12, 2022 •

edited

Loading

const-t left a comment

const-t commented Oct 11, 2022 •

edited

Loading

b3b left a comment

b3b commented Nov 1, 2022

b3b commented Nov 10, 2022

RomanBelozerov commented Nov 14, 2022

b3b left a comment

const-t left a comment

reworked long body tests #304

reworked long body tests #304

Conversation

RomanBelozerov commented Sep 12, 2022 • edited Loading

const-t left a comment

Choose a reason for hiding this comment

const-t commented Oct 11, 2022 • edited Loading

b3b left a comment

Choose a reason for hiding this comment

b3b commented Nov 1, 2022

b3b commented Nov 10, 2022

RomanBelozerov commented Nov 14, 2022

b3b left a comment

Choose a reason for hiding this comment

const-t left a comment

Choose a reason for hiding this comment

RomanBelozerov commented Sep 12, 2022 •

edited

Loading

const-t commented Oct 11, 2022 •

edited

Loading