Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Using addCleanup() instead of TearDown(). #562

Merged
merged 33 commits into from
Jan 23, 2024
Merged

Using addCleanup() instead of TearDown(). #562

merged 33 commits into from
Jan 23, 2024

Conversation

ykargin
Copy link
Contributor

@ykargin ykargin commented Jan 8, 2024

Fix #534

@ykargin ykargin requested a review from RomanBelozerov January 8, 2024 11:17
@ykargin ykargin self-assigned this Jan 8, 2024
RomanBelozerov
RomanBelozerov requested changes Jan 8, 2024
View reviewed changes
Copy link
Contributor

@RomanBelozerov RomanBelozerov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. You should remove empty tearDown methods or you must call super().tearDown()
  2. You should not to add tearDown to cleanup functions. This method will be called after test anyway.
  3. I think there is not need to rewrite tearDown for tests inherited from FunctionalTests and StressTests. This is old framework and it will be reworked in Rework the test suite #56

framework/tester.py Outdated Show resolved Hide resolved
framework/tester.py Outdated Show resolved Hide resolved
reconf/reconf_stress.py Outdated Show resolved Hide resolved
very_many_backends/multi_backend.py Outdated Show resolved Hide resolved
very_many_backends/test_deadtime_1M.py Outdated Show resolved Hide resolved
ykargin added 27 commits January 16, 2024 14:04
@ykargin
test_ws_ping: Replace tearDown() with addCleanup() for process termin…
4978a16 
…ation

Signed-off-by: Yaroslav Kargin <yk@tempesta-tech.com>
@ykargin
tester.py: Replace tearDown() with addCleanup().
9b2edba 
Signed-off-by: Yaroslav Kargin <yk@tempesta-tech.com>
@ykargin
test_headercollection.py: Replace tearDown() with addCleanup().
6eb176b 
Signed-off-by: Yaroslav Kargin <yk@tempesta-tech.com>
@ykargin
stress.py: Replace tearDown() with addCleanup().
69032af 
Signed-off-by: Yaroslav Kargin <yk@tempesta-tech.com>
@ykargin
test_x509.py: Replace tearDown() with addCleanup().
0bd7b25 
Signed-off-by: Yaroslav Kargin <yk@tempesta-tech.com>
@ykargin
A small typo correction
a375f4b 
Signed-off-by: Yaroslav Kargin <yk@tempesta-tech.com>
@ykargin
reconf_stress.py: Replace tearDown() with addCleanup().
54fa591 
Signed-off-by: Yaroslav Kargin <yk@tempesta-tech.com>
@ykargin
test_sockets.py: Replace tearDown() with addCleanup().
6e954ad 
Signed-off-by: Yaroslav Kargin <yk@tempesta-tech.com>
@ykargin
mixins.py: Replace tearDown() with addCleanup().
f27dd9a 
Signed-off-by: Yaroslav Kargin <yk@tempesta-tech.com>
@ykargin
test_reboot.py: Replace tearDown() with addCleanup().
b1ccebe 
Signed-off-by: Yaroslav Kargin <yk@tempesta-tech.com>
@ykargin
test_shutdown.py: Replace tearDown() with addCleanup().
4c592e0 
Signed-off-by: Yaroslav Kargin <yk@tempesta-tech.com>
@ykargin
test_deproxy.py: Replace tearDown() with addCleanup().
c19d450 
Signed-off-by: Yaroslav Kargin <yk@tempesta-tech.com>
@ykargin
test_deproxy_message.py:
1fc9d45 
* Replace tearDown() with addCleanup().
* Minor typo fix

Signed-off-by: Yaroslav Kargin <yk@tempesta-tech.com>
@ykargin
test_requests.py: Replace tearDown() with addCleanup().
f893c92 
Signed-off-by: Yaroslav Kargin <yk@tempesta-tech.com>
@ykargin
test_responses.py: Replace tearDown() with addCleanup().
b9b6fb7 
Signed-off-by: Yaroslav Kargin <yk@tempesta-tech.com>
@ykargin
frang_test_case.py: Replace tearDown() with addCleanup().
5170e5a 
Signed-off-by: Yaroslav Kargin <yk@tempesta-tech.com>
@ykargin
test_http_tables.py: Replace tearDown() with addCleanup().
5ca351e 
Signed-off-by: Yaroslav Kargin <yk@tempesta-tech.com>
@ykargin
test_long_request.py: Replace tearDown() with addCleanup().
ffd472c 
Signed-off-by: Yaroslav Kargin <yk@tempesta-tech.com>
@ykargin
test_stress.py: Replace tearDown() with addCleanup().
c78b52a 
Signed-off-by: Yaroslav Kargin <yk@tempesta-tech.com>
@ykargin
functional.py: Replace tearDown() with addCleanup().
65db7d6 
Signed-off-by: Yaroslav Kargin <yk@tempesta-tech.com>
@ykargin
multi_backend.py: Replace tearDown() with addCleanup().
e4684e6 
Signed-off-by: Yaroslav Kargin <yk@tempesta-tech.com>
@ykargin
test_deadtime_1M.py: Replace tearDown() with addCleanup().
3c0d840 
Signed-off-by: Yaroslav Kargin <yk@tempesta-tech.com>
@ykargin
Apply Black code formatter
06b7d77 
Signed-off-by: Yaroslav Kargin <yk@tempesta-tech.com>
@ykargin
Removed outdated comment
cbcdc09 
Signed-off-by: Yaroslav Kargin <yk@tempesta-tech.com>
@ykargin
Revert "test_deproxy.py: Replace tearDown() with addCleanup()."
31ad983 
This reverts commit 1a77d1e.
No need to modify old-framework based tests
@ykargin
Revert "test_shutdown.py: Replace tearDown() with addCleanup()."
3b1474f 
This reverts commit f3b5343.
No need to modify old-framework based tests
@ykargin
Revert "functional.py: Replace tearDown() with addCleanup()."
8901750 
This reverts commit 935eb70.
No need to modify old-framework based tests
@ykargin ykargin force-pushed the yk-534-add-cleanup branch from 8ceca1a to 8901750 Compare January 16, 2024 11:06
@ykargin
Fix: AttributeError: 'FrangHostRequiredH2TestCase' object has no
d371ce0 
attribute 'oops' for tester.py

Signed-off-by: Yaroslav Kargin <yk@tempesta-tech.com>
@ykargin
Fix error reporting for test_http_tables.py
7ae7c73 
Signed-off-by: Yaroslav Kargin <yk@tempesta-tech.com>
@ykargin
Fix: cleanup
8fb0952 
Signed-off-by: Yaroslav Kargin <yk@tempesta-tech.com>
@ykargin
Cleanup: removed empty tearDowns
f8aa55a 
Signed-off-by: Yaroslav Kargin <yk@tempesta-tech.com>
@ykargin
Removed useless addCleanup() calls
5175677 
Signed-off-by: Yaroslav Kargin <yk@tempesta-tech.com>
@ykargin
Removed redundant addCleanup calls for tearDown in tests
c3eb1d9 
Signed-off-by: Yaroslav Kargin <yk@tempesta-tech.com>
@ykargin ykargin force-pushed the yk-534-add-cleanup branch from 2f1f7e0 to c3eb1d9 Compare January 22, 2024 21:26
@ykargin ykargin merged commit a001eff into master Jan 23, 2024
1 check passed
@ykargin ykargin deleted the yk-534-add-cleanup branch June 19, 2024 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Vitaly-Skopets Vitaly-Skopets Vitaly-Skopets left review comments

@RomanBelozerov RomanBelozerov RomanBelozerov approved these changes

Assignees

@ykargin ykargin

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rewrite tearDown methods to cleanups (addCleanup)
3 participants
@ykargin @RomanBelozerov @Vitaly-Skopets