Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct link to patchset #1069

Merged
merged 2 commits into from
Sep 27, 2018
Merged

Correct link to patchset #1069

merged 2 commits into from
Sep 27, 2018

Conversation

craig
Copy link
Contributor

@craig craig commented Sep 27, 2018

No description provided.

Copy link
Contributor

@vankoven vankoven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for contribution! A small fix is required though.

README.md Outdated
@@ -14,7 +14,7 @@ performance characteristics in comparison with TCP servers on top of common
Socket API or even kernel sockets.

We do our best to keep the kernel modifications as small as possible. Current
[patch](https://github.com/tempesta-tech/tempesta/blob/master/linux-4.9.35.patch)
[patch](https://github.com/tempesta-tech/linux-4.14.32-tfw)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for notice! But we should keep the link to the patch located in the current repository. You're right, we use tempesta-tech/linux-4.14.32-tfw repo to develop the kernel patch required for Tempesta. But the patch itself is small and can be rather easily ported to other kernel versions, e.g. Debian doesn't use the vanilla kernel. That's why the link is for the patch located in the current repository.

So the correct link will be https://github.com/tempesta-tech/tempesta/blob/master/linux-4.14.32.patch. Could you please fix this?

Copy link
Contributor

@vankoven vankoven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to merge. Thank you for contribution!

@vankoven vankoven merged commit 871200e into tempesta-tech:master Sep 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants