copy network headers in ss_skb_split() #1100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We need to copy network headers from the original skb to the newly allocated remainder, as ss_skb_fmt_src_addr() expects at least IP headers.
vankoven
approved these changes
Nov 15, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With HTTP request pipelining, multiple requests can fit into a single network packet, and so end up sharing the same
struct sk_buff. In that case, after processing the first request,struct sk_buffis split into two, with remaining data going into anothersk_buff. However, newly createdstruct sk_buffhas no IP header, albeit has enough room reserved. That causesss_skb_fmt_src_addr()used in address extraction forX-Forwarded-Forheader field, to use uninitialized data.The patch adds needed header copying.
(related to #1099)