Limit upper border for JS challenge to deny hardcoding the challenge #1109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krizhanovsky
approved these changes
Nov 22, 2018
There was a problem hiding this comment.
Good to merge. The problem is pretty subtle, so please update the Wiki describing the JavaScript challenge. Since the problem with coming back client described by @i-rinat (a client received the challenge, but just closed a browser and visits the resource after that) isn't fixed, then please leave #1102 open and let's close it when we fix it with Max-Age cookie attribute on in some other way.
Detailed information in my comment to #1102 issue
vankoven
force-pushed
the
ik-jsch-upper-border
branch
from
6ba944f
to
cdd449d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Detailed information in my comment to #1102 issue