Parse "pragma" field in response, honor "pragma" field in request #1120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are no anything about "Pragma" in response headers, but at least Firefox and Chrome/Chromium recognize that field in response headers, and do not cache such responses.
vankoven
approved these changes
Nov 28, 2018
| @@ -724,6 +724,10 @@ enum { | |||
|
|
|||
| I_EoT, /* end of term */ | |||
| I_EoL, | |||
|
|
|||
| /* Pragma header */ | |||
| I_Pragma, | |||
There was a problem hiding this comment.
Not a big deal, just seems like End of Term and End of Line should be last in the enumeration and Pragma header enum values should stand closer to other headers enums. Look a little bit messy as for me.
There was a problem hiding this comment.
Made follow-up changes in #1124.
| @@ -1001,6 +1001,62 @@ TEST(http_parser, fills_hdr_tbl_for_resp) | |||
| } | |||
| } | |||
|
|
|||
| TEST(http_parser, cache_control_flags) | |||
There was a problem hiding this comment.
New tests are only about parsing responses, requests are not checked, not all TFW_HTTP_CC_* flags are tested. No need to address this comment in the PR, since functional tests from tempesta-tech/tempesta-test#59 will cover the some cases. Just wanted to link this test case with #1059 issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The patchset extends "pragma" field processing a bit. It's now parsed in both request and response headers. Also, both sources are used to decide whenever to cache a response.
Although RFC 7234, 5.4 doesn't explicitly specify meaning of "
Pragma: no-cache" in response header, it is still used by various user agents — at least Firefox and Chromium — perhaps for compatibility reasons. So we probably want to abstain from caching if response comes with "pragma: no-cache" too, even if it's not a standard-compliant behavior.(fixes #1116)