Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move http parser to connection #1138

Merged
merged 3 commits into from
Dec 27, 2018
Merged

Conversation

vankoven
Copy link
Contributor

There is no need to allocate a new instance of http parser for each incoming message. It can be allocated once per connection.

Copy link
Contributor

@i-rinat i-rinat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Copy link
Contributor

@aleksostapenko aleksostapenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to merge, with minor cleanup.

* Headers unconditionally treated as hop-by-hop must be listed in
* tfw_http_init_parser_req()/tfw_http_init_parser_resp() functions and must be
* members of Special headers.
* group.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

group looks like redundant word here.

Copy link
Contributor

@krizhanovsky krizhanovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!

@vankoven vankoven merged commit 3c278c6 into master Dec 27, 2018
@vankoven vankoven deleted the ik-move-parser-to-connection branch December 27, 2018 23:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants