Fix tls.test_tls_cert.RSA512_SHA256 test #1479
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ificate with a key smaller than 1024 bits. Do not check ctx->padding since we check it before the function calls. Small coding style cleanups.
krizhanovsky
added a commit
to tempesta-tech/tempesta-test
that referenced
this pull request
Dec 12, 2020
in the pool on large RSA keys. Fix errors counting in __rsa_setup_ctx(). Simplify per cpu reading in the mpool code.
vankoven
approved these changes
Dec 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Print warning and exit with error if a user tries to load an RSA certificate with a key smaller than 1024 bits.
Do not check ctx->padding since we check it before the function calls.
Small coding style cleanups.
Note that
__rsa_setup_ctx()during thefor_each_possible_cpu()loop uses current CPU stack for all the big integer allocations, includingttls_mpi_inv_mod()andttls_mpi_exp_mod(), and that's OK since the function is called on configuration time only and the stack allocations are used for temporal data only.