Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Custom HTTP redirects #1618

Merged
merged 3 commits into from
May 6, 2022
Merged

Custom HTTP redirects #1618

merged 3 commits into from
May 6, 2022

Conversation

avbelov23
Copy link
Contributor

@avbelov23 avbelov23 requested a review from krizhanovsky April 22, 2022 13:47
@avbelov23
Copy link
Contributor Author

Perhaps it would be convenient for ease of inserting variable values into placeholders ($host, $request_uri) at the config stage to break the redir url into chunks

krizhanovsky
krizhanovsky requested changes May 3, 2022
View reviewed changes
Copy link
Contributor

@krizhanovsky krizhanovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code does work except $host variable, but there are things to optimize and improve, which are good to make before the merge.

fw/http_tbl.c Outdated Show resolved Hide resolved
fw/http_tbl.c Outdated Show resolved Hide resolved
fw/http_tbl.c Outdated Show resolved Hide resolved
fw/http_tbl.c Outdated Show resolved Hide resolved
fw/http.c Outdated Show resolved Hide resolved
fw/http.c Outdated Show resolved Hide resolved
fw/http_tbl.h Outdated Show resolved Hide resolved
fw/http.c Outdated Show resolved Hide resolved
fw/http.c Outdated Show resolved Hide resolved
fw/http.c Outdated Show resolved Hide resolved
krizhanovsky
krizhanovsky reviewed May 3, 2022
View reviewed changes
fw/http.c Show resolved Hide resolved
krizhanovsky
krizhanovsky approved these changes May 6, 2022
View reviewed changes
Copy link
Contributor

@krizhanovsky krizhanovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's merge it and do refactoring on the next week

fw/http.c Show resolved Hide resolved
@avbelov23 avbelov23 merged commit b68c821 into master May 6, 2022
@avbelov23 avbelov23 deleted the avb-856 branch May 6, 2022 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krizhanovsky krizhanovsky krizhanovsky approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@avbelov23 @krizhanovsky