Fix minor warning for #1377 #1632
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nginx), then tfw_hpack_node_compare() may raise WARN_ON_ONCE(state != HPACK_HDR_VALUE_FOUND). In case of empty header tfw_hpack_add_node() -> tfw_http_hdr_split() strips spaces and ':' so we may fall to the warning statement with matching the header name only, but HPACK_HDR_OWS_PROCESS() didn't move @State to HPACK_HDR_NAME_FOUND (beacuse no spaces and no ':'). The patch moves the @HDR processing tail out of the loop, so hlen might be non-zero after the main loop and WARN_ON_ONCE(hlen) is also eliminated.
|
Going to assume the mention was unintentional 😄 |
@HDR, Yes, sorry - just copy & pasted comment with doxygen's |
s0nx
approved these changes
Jun 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a server sends empty header (e.g.
add_header X-Crash-1377 ' ';for Nginx), thentfw_hpack_node_compare()may raiseWARN_ON_ONCE(state != HPACK_HDR_VALUE_FOUND).In case of empty header
tfw_hpack_add_node()->tfw_http_hdr_split()strips spaces and ':' so we may fall to the warning statement with matching the header name only, butHPACK_HDR_OWS_PROCESS()didn't movestatetoHPACK_HDR_NAME_FOUND(beacuse no spaces and no ':').The patch moves the
hdrprocessing tail out of the loop, so hlen might be non-zero after the main loop andWARN_ON_ONCE(hlen)is also eliminated.