Sched/rr #17
Merged
Sched/rr #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| return len; | ||
| } | ||
|
|
||
|
|
Also remove support of runtime scheduler switching, it is not needed anymore.
This one is based on a statically-allocated per-CPU array instead of a shared linked list. Now the get() doesn't use locking and thus should operate much faster. Also there should be a little improvement on NUMA systems because get() now references only local per-CPU variable. The debugfs wrapper implementation is also simplified.
| .counter = 0, | ||
| .servers = { NULL } | ||
| }; | ||
|
|
There was a problem hiding this comment.
BTW,
CPU != socket != NUMA node
We have a local copy for each core (or even each "virtual" core in case of Hyper-Threading).
That should give a positive performance impact for non-shared caches, but negative impact for shared caches.
For non-shared caches (presumably L1d for "real" cores) that should eliminate the cache line bouncing.
For shared caches (presumably L2 and L3) it increases a chance of discarding by an LRU algorithm.
I can't estimate which factor would dominate on a real system.
There was a problem hiding this comment.
That's ok for now. More fine grined optimization is reachable only by real benchmarks.
related to: #5 - Load balancing
vdmit11
added a commit
that referenced
this pull request
Sep 26, 2014
The round-robin scheduler implementation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basic round-robin scheduler implementation.