Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix long work test on big server #2236

Merged
merged 1 commit into from
Sep 19, 2024
Merged

Fix long work test on big server #2236

merged 1 commit into from
Sep 19, 2024

Conversation

EvgeniiMekhanik
Copy link
Contributor

There is no crash in unittests described in #2222

  • everything is ok, but test works too long (about 30 minutes), because of a lot of cpu in system. Fix test
  • now if count of cpu is greater then 32 count of workers == count of cpu not count of cpu * 10.

Closes #2222

krizhanovsky
krizhanovsky approved these changes Sep 10, 2024
View reviewed changes
Copy link
Contributor

@krizhanovsky krizhanovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

const-t
const-t approved these changes Sep 13, 2024
View reviewed changes
Copy link
Contributor

@const-t const-t left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Seems single consumer can't pop items for the reasonable time in case a lot of cpus.

fw/t/unit/test_wq.c Outdated
}


Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Extra line break

@EvgeniiMekhanik
Fix long work test on big server
3f586a1 
There is no crash in unittests described in #2222
- everything is ok, but test works too long (about 30
minutes), because of a lot of cpu in system. Fix test
- now if count of cpu is greater then 32 count of
workers == count of cpu not count of cpu * 10.

Closes #2222
@krizhanovsky krizhanovsky merged commit a8e2a46 into master Sep 19, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@const-t const-t const-t approved these changes

@krizhanovsky krizhanovsky krizhanovsky approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tempesta unittests crash
3 participants
@EvgeniiMekhanik @krizhanovsky @const-t