Fix the connection destruct procedure #412
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if (tfw_http_adjust_resp(resp, req)) | ||
| goto resp_err; | ||
| if (tfw_cli_conn_send(req->conn, (TfwMsg *)resp, true)) | ||
| goto resp_err; |
There was a problem hiding this comment.
It seems there is no sense to try to send client an error message if we couldn't send them normal message. When error message can be sent if normal message can't?
keshonok
force-pushed
the
ab-refix-destruct
branch
from
9eb5ddd to
9935561
Compare
keshonok
force-pushed
the
ab-refix-destruct
branch
from
9935561 to
97b562d
Compare
The previous fix has a subtle bug. Suppose a server has transmitted a part of a response (the result of parsing is TFW_POSTPONE) and died. tfw_sock_srv_do_failover() is called in that case, and @conn->refcnt is greater that one at that time. @conn->refcnt is decremented in tfw_sock_srv_do_failover(), but there's still the reference from the incomplete response, so the connection destruction procesure does not proceed to the final connection release stage. No data is coming from the server anymore, so the response stays in the postponed state. Therefore it's never freed and it never releases that extra reference to the connection to allow the connection destruction procedure to proceed to the final stage. The most visible consequence of that is that the connection to the server is never restored. The fix splits the connection destruction procedure in two parts. One is executed at the time the connection is dropped, and the other is executed when the connection is finally released after there are no more users of the connection.
keshonok
force-pushed
the
ab-refix-destruct
branch
from
97b562d to
b653ce8
Compare
|
Good to merge |
keshonok
added a commit
that referenced
this pull request
Feb 9, 2016
Fix the connection destruct procedure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.