switch from sk_destruct to TfwConnection->destruct #59
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before the commit TfwConnection-related code was overwriting the
sk_destruct field of struct sock with a custom destructor function.
The original sk_destruct function was saved in TfwConnection and
had to be called manually from the custom destructor.
This change simply moves the destructor from sk_destruct to the
TfwConnection->destruct field. Now you don't need to call the
original socket destructor manually, and the field was occupied
anyway, so this commit makes code simpler for free.