Fix #903: add logging for all error responses. #952
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krizhanovsky
approved these changes
Mar 13, 2018
tempesta_fw/http.c
Outdated
| tfw_http_send_resp(TfwHttpReq *req, int status, const char *reason) | ||
| { | ||
| if (!(tfw_blk_flags & TFW_BLK_ERR_NOLOG)) | ||
| TFW_WARN_ADDR(reason, &req->conn->peer->addr); |
There was a problem hiding this comment.
Please add the status to the warning message, to get something like:
[tempesta] Warning: request dropped: processing error, status 502: ::ffff:c0a8:6401
For more verbose logging we have #537, but now we still need something more administration-friendly.
vankoven
approved these changes
Mar 13, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.