Remove requests from fwd_list and put connections of requests freeing #960
Conversation
…ss(). 2. #959: print a warning and let the system crash if we can't remove a server grooup. 3. Add req->fwd_list and req->nip_list warnings to make sure that the req is removed from the list when we go to code where we don't have a pointer to the server connection. 4. Replace tfw_http_msg_free() by tfw_http_conn_msg_free() in couple of places to put connections on requests freeing to avoid memory leakage on connections reference counters. 5. Code leanups all around.
| @@ -547,7 +547,8 @@ tfw_sg_wait_release(void) | |||
| TFW_WARN_NL("pending for server callbacks to complete " | |||
| "for 5s, %ld server groups still exist\n", | |||
| atomic64_read(&act_sg_n)); | |||
| tend = jiffies + HZ * 5; | |||
| __WARN(); | |||
There was a problem hiding this comment.
Ok. Should I rollback the change or will you just overwrite it by your patch?
There was a problem hiding this comment.
I'll overwrite it. Anyway I'll need to rebase my branch to comply this PR.
| bad_req = hmresp->req; | ||
| tfw_http_req_delist((TfwSrvConn *)conn, bad_req); |
There was a problem hiding this comment.
My understanding is that we get here in all of the outcomes from the parser or GFSM: PASS, BLOCK, POSTPONE. My concern is a tricky case when the server considers a response NOT transmitted successfully. That may happen in BLOCK or POSTPONE cases. Will the server attempt to retransmit the response after the connection is restored? If so, the pairing of requests and responses must be maintained, and I am not sure that this situation is handled well in either patched or unpatched code.
tempesta_fw/http.c
Outdated
| * TODO #687: this is the only place where req_qlock is used. Instead | ||
| * of competing for the lock from different softirqs, just process | ||
| * the next available response, set a flag for current softirq | ||
| * processing ret_queue and make the current softire retry from |
server grooup.
is removed from the list when we go to code where we don't have a pointer
to the server connection.
places to put connections on requests freeing to avoid memory leakage
on connections reference counters.