fix wrk command #966
Merged
fix wrk command #966
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vankoven
approved these changes
Mar 19, 2018
| @@ -162,6 +162,8 @@ def form_command(self): | |||
| # count for remote node. | |||
| if self.threads == -1: | |||
| self.threads = remote.get_max_thread_count(self.node) | |||
| if self.threads > self.connections: | |||
| self.threads = self.connections | |||
There was a problem hiding this comment.
If self.connections is not multiple of self.threads, then wrk will establish only threads * (connections // threads) connections. The other connections % threads connections will be ignored. Is it worth to print warning in this case, what do you think?
There was a problem hiding this comment.
Good idea, I will add such warning
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If number of CPU is more than number of connection, create only number_of_connections threads