Test control #968
Merged
Test control #968
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vladtcvs
force-pushed
the
vlts-test-module
branch
2 times, most recently
from
38481b6
to
98072d5
Compare
vankoven
reviewed
Mar 20, 2018
| @@ -0,0 +1,89 @@ | |||
| import unittest | |||
| from helpers import shell, remote | |||
|
|
|||
There was a problem hiding this comment.
- Missing copyright.
- Need to document in Readme.md, why the file is needed, file docstring is required. Just to make clear that the file is not intended to be started manually
| shell.testsuite_flatten(all_tests, loader.discover('.')) | ||
| self.v_level = v_level | ||
| self.tests = [TempestaTest(t) for t in all_tests] | ||
| remote.connect() |
There was a problem hiding this comment.
How about nofile limit? Should it be defined here?
| testsuite = unittest.TestSuite(pending) | ||
| testRunner = unittest.runner.TextTestRunner(verbosity=self.v_level, | ||
| resultclass=self.__resultclass()) | ||
| testRunner.run(testsuite) |
There was a problem hiding this comment.
How can we care about kernel crashes? E.g. crash happens during one tests and all the following testa are failed.
vladtcvs
force-pushed
the
vlts-test-module
branch
from
15657c2
to
da88c1d
Compare
vankoven
approved these changes
Mar 21, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.